-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-cli-syntax as flaky/unreliable #24957
Conversation
CI: https://ci.nodejs.org/job/node-test-pull-request/19422/ (remembering to check CERTIFY_SAFE this time...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks 💯 correct to me!
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19428/ |
Landed in 73ebfc2 |
Refs: nodejs#24403 PR-URL: nodejs#24957 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Refs: nodejs#24403 PR-URL: nodejs#24957 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Collaborators, 👍 here to fast-track.
I hate to do this with a bug that occurs so frequently in CI and is likely to be significant in some environments, but if a fix isn't imminent, this is the right thing to do, I suppose...
Refs: #24403
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes